Skip to content

fix: fix approving task bug#2288

Merged
fit2-zhao merged 1 commit into
mainfrom
pr@main@fix_bugs_approval_task_0518
May 19, 2026
Merged

fix: fix approving task bug#2288
fit2-zhao merged 1 commit into
mainfrom
pr@main@fix_bugs_approval_task_0518

Conversation

@fit2-zhao

Copy link
Copy Markdown
Member

fix: fix approving task bug

@f2c-ci-robot

f2c-ci-robot Bot commented May 18, 2026

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot

f2c-ci-robot Bot commented May 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wangxu10 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Somebody-JIAN
Somebody-JIAN force-pushed the pr@main@fix_bugs_approval_task_0518 branch from 6fc1291 to 5928d3a Compare May 18, 2026 12:57
@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 32.56%. Comparing base (0f4453b) to head (5928d3a).
⚠️ Report is 620 commits behind head on main.

Files with missing lines Patch % Lines
...rdys/crm/approval/service/ApprovalTodoService.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2288      +/-   ##
============================================
- Coverage     33.29%   32.56%   -0.73%     
- Complexity     1946     2218     +272     
============================================
  Files           382      425      +43     
  Lines         21892    25573    +3681     
  Branches       2309     2745     +436     
============================================
+ Hits           7289     8329    +1040     
- Misses        14042    16555    +2513     
- Partials        561      689     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fit2-zhao
fit2-zhao merged commit 4b79aad into main May 19, 2026
6 of 8 checks passed
@fit2-zhao
fit2-zhao deleted the pr@main@fix_bugs_approval_task_0518 branch May 19, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants